Paste number 96515: avoid ref/unref

Paste number 96515: avoid ref/unref
Pasted by: zecke
When:1 year, 10 months ago
Share:Tweet this! | http://paste.lisp.org/+22GZ
Channel:#webkit-gtk
Paste contents:
Raw Source | XML | Display As
diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index d79cc34..11f0e99 100644
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,17 @@
+2010-03-17  Holger Hans Peter Freyther  <zecke@selfish.org>
+
+        Reviewed by NOBODY (OOPS!).
+
+        [Gtk+] Avoid copying the HTTPHeaderMap.
+
+        ResourceRequest::httpHeaderFields is returning a const
+        reference but we were storing it as a simple value which
+        meant that we were copying data even if there is no need
+        to copy it.
+
+        * platform/network/soup/ResourceRequestSoup.cpp:
+        (WebCore::ResourceRequest::toSoupMessage):
+
 2010-03-16  John Abd-El-Malek  <jam@chromium.org>
 
         Reviewed by Darin Fisher.
diff --git a/WebCore/platform/network/soup/ResourceRequestSoup.cpp b/WebCore/platform/network/soup/ResourceRequestSoup.cpp
index 8e4507c..593e421 100644
--- a/WebCore/platform/network/soup/ResourceRequestSoup.cpp
+++ b/WebCore/platform/network/soup/ResourceRequestSoup.cpp
@@ -39,7 +39,7 @@ SoupMessage* ResourceRequest::toSoupMessage() const
     if (!soupMessage)
         return 0;
 
-    HTTPHeaderMap headers = httpHeaderFields();
+    const HTTPHeaderMap& headers = httpHeaderFields();
     SoupMessageHeaders* soupHeaders = soupMessage->request_headers;
     if (!headers.isEmpty()) {
         HTTPHeaderMap::const_iterator end = headers.end();

This paste has no annotations.

Colorize as:
Show Line Numbers

Lisppaste pastes can be made by anyone at any time. Imagine a fearsomely comprehensive disclaimer of liability. Now fear, comprehensively.